The addition of an r_solver field to an r_def field is not supported in PSyclone
- Dominant language
- Python
- Stars
- 3
- Forks
- 2
- PR merge metrics
- No merged PRs in 30d
Description
Being able to add an `r_def` field to an `r_solver` field is not supported in PSyclone and is needed in the LFRic apps algorithm `science/gungho/source/algorithm/solver/semi_implicit_solver_alg_mod.x90`.
This problem is currently averted by the use of the PSyKAl-lite routine `invoke_inc_rdefX_plus_rsolverY`, found in LFRic core at `components/science/source/psy/sci_psykal_light_mod`. Ideally, this should be addressed and removed. This currently does not have a related PSyclone issue listed in the code.
Contributor guide
No contributing guide indexed for this repository
Research direction
Start with the failing use in science/gungho/source/algorithm/solver/semi_implicit_solver_alg_mod.x90 and the workaround invoke_inc_rdefX_plus_rsolverY in components/science/source/psy/sci_psykal_light_mod. Trace how PSyclone handles the r_def plus r_solver operation, then verify that the workaround can be removed while the LFRic algorithm remains supported.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- fortran, python
- Domain
- compilers
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100