MetOffice / MetOffice/PSyTran

Mixed precision builtins in PSyclone

Open
#78 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

LFRic core PSyclone issue PSyKAl-lite
Dominant language
Python
Stars
3
Forks
2
PR merge metrics
No merged PRs in 30d

Description

Due to PSyclone not previously supporting mixed precision builtins, the following
routines were made:

- `invoke_rdouble_X_innerproduct_X`
- `invoke_rdouble_X_innerproduct_Y`

These can be found in `components/science/source/psy/sci_psykal_light_mod`, and are both called by `components/science/source/algorithm/solver/sci_r_solver_field_vector_mod.x90`.

The related PSyclone issue is [#1786](https://github.com/stfc/PSyclone/issues/1786). These routines are currently being deprecated in [LFRic ticket #4449](https://code.metoffice.gov.uk/trac/lfric/ticket/4449), which is currently in review.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Read invoke_rdouble_X_innerproduct_X and invoke_rdouble_X_innerproduct_Y in components/science/source/psy/sci_psykal_light_mod, then trace their calls from components/science/source/algorithm/solver/sci_r_solver_field_vector_mod.x90. Check PSyclone issue #1786 and LFRic ticket #4449 first; the ticket’s review status suggests the required change may already be moving elsewhere, so confirm the intended end state before starting.

Written by the indexing model from the issue text.

Assessment

Tech stack
fortran, python
Domain
tooling
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
20/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.