MetOffice / MetOffice/PSyTran

Loop nest

Open
#56 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
Python
Stars
3
Forks
2
PR merge metrics
No merged PRs in 30d

Description

`is_perfectly_nested` now accepts either the outer-loop of a nest, or a list representing the loop nest as input. We should do the same for `is_simple_loop` and `get_loop_nest_variable_names`.

However, this does make me wonder whether PSyACC (or indeed PSyclone) is missing a `LoopNest` class, which could encapsulate the nest more appropriately than having a list (that we have to keep checking is comprised of `Loop`s).

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading the existing is_perfectly_nested implementation, then inspect the definitions and call sites for is_simple_loop and get_loop_nest_variable_names. Confirm how loop nests are represented and make both functions accept either an outer Loop or a list consistently; separately clarify whether a LoopNest abstraction is in scope.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
tooling
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.