MetOffice / MetOffice/CSET

Null valued facets cause the web interface to crash when populating the sidebar

Open
#2,171 0 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
Python
Stars
33
Forks
19
Avg merge
1d 22h
Merged PRs (30d)
30

Description

### Describe the bug

It looks like it is failing as there is a facet with the value null, or None in python.

JavaScript can't natively turn a null value into a string, so when it tries it is crashing.

### How to reproduce

Steps to reproduce the behaviour:

1. Visit https://wwwspice/~david.flack/CSET_SCZ_part6/
2. Open the devtools console.
3. Observe the crash.

### Expected behaviour

Instead we need to capture null values, and either filter out facets with null values, or manually convert them to strings.

Contributor guide

No contributing guide indexed for this repository

Research direction

Reproduce the crash at the linked CSET dataset URL and inspect the browser console while the sidebar facets are populated. Trace the web interface code that handles facet values, then verify that a null-valued facet no longer crashes the sidebar and that the chosen handling matches the expected behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, python
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.