MetOffice / MetOffice/CSET

Test loaders

Open
#1,739 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
33
Forks
19
Avg merge
1d 22h
Merged PRs (30d)
30

Description

The change itself is trivial, but as it has the potential to break multiple recipes I think there should be some sort of regression test for this. If we want to get this PR in quickly then maybe that could be a separate issue?

_Originally posted by @SGallagherMet in https://github.com/MetOffice/CSET/pull/1721#pullrequestreview-3270901422_

We currently don't have any testing on loaders, which means we don't have the protection against regression that we would like for them.

We should add regression tests here. The big question is how. While we could individually test each loader, that would be a lot of work that isn't likely to produce a large gain, as each loader is supposedly independent.

Do we just need a single config with all diagnostics enabled, that we verify against?

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by reviewing the loader implementations and the recipes they support, then inspect how a configuration with all diagnostics enabled is processed. Compare whether one representative configuration provides useful regression coverage or whether loaders need separate cases. Done means regression tests cover the agreed loader behavior and fail when a loader breaks.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
testing
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Needs clarification
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.