MetOffice / MetOffice/CSET

Generalise the _fix_cell_methods loading callback.

Open
#1,706 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
33
Forks
19
Avg merge
1d 22h
Merged PRs (30d)
30

Description

### Something else
The `_fix_cell_methods` loading callback correctly identifies that Iris' cell methods do not always correctly identify the type of processing that has been applied to the cube. However, the current fix of converting 'mean' to 'sum' for specific STASH codes is too generic as the STASH system is capable of various types of processing (off the top of my head, at least mean, minimum and maximum over a defined period).

Ideally this callback would check the UM field codes as defined in UMDPF03 to see what processing was actually applied and assign an appropriate cell method based on that.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by locating the `_fix_cell_methods` loading callback and reviewing how it maps STASH codes to cell methods. Consult the UM field codes defined in UMDPF03 to identify the processing applied, including mean, minimum, and maximum over a defined period. Done means the callback assigns the appropriate cell method rather than applying a generic mean-to-sum conversion.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
data
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.