MetOffice / MetOffice/CDDS

CMOR frequency is only set for CMIP7 processing

Open
#831 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
8
Forks
7
Avg merge
1d 15h
Merged PRs (30d)
23

Description

CMOR frequency set here

https://github.com/MetOffice/CDDS/blob/59224df35cddc943456976b1c1f1491c466621ae/mip_convert/mip_convert/requested_variables.py#L125-L126

But from the looks of it will only be set for CMIP7

https://github.com/MetOffice/CDDS/blob/59224df35cddc943456976b1c1f1491c466621ae/mip_convert/mip_convert/request.py#L114-L115

Brought in with this change.

https://github.com/MetOffice/CDDS/commit/1ee998f5f6a5be453d7b653b3933428bbd480edd

Probably not a problem but probably a good idea to make the behaviour consistent across all processing.

Contributor guide

No contributing guide indexed for this repository

Research direction

Read the referenced sections of mip_convert/requested_variables.py and mip_convert/request.py, then compare how CMOR frequency is assigned for CMIP7 and other processing paths. Trace the change introduced by commit 1ee998f5f6a5be453d7b653b3933428bbd480edd and verify that frequency handling is consistent across all processing modes.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
data-engineering
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
52/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.