MetOffice / MetOffice/CDDS

Make use of or remove the DatasetFactory class

Open
#829 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
8
Forks
7
Avg merge
1d 15h
Merged PRs (30d)
23

Description

As it stands the `DatasetFactory` class isn't actually used. I assume it was implemented with the intention to replace the logic here.

https://github.com/MetOffice/CDDS/blob/d04ff181c65ada49312bdeddaeeba615e1ce0476/cdds/cdds/qc/command_line.py#L155-L164

So we should either make use of it or remove it.

Contributor guide

No contributing guide indexed for this repository

Research direction

Inspect the DatasetFactory class and the logic in cdds/cdds/qc/command_line.py at lines 155-164. Determine whether the existing command-line path should use DatasetFactory or whether the unused class should be removed, then verify that the QC command-line behavior remains intact.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
cli
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.