Logic in check_conventions_version qc plugins is misleading
- Dominant language
- Python
- Stars
- 8
- Forks
- 7
- Avg merge
- 1d 15h
- Merged PRs (30d)
- 23
Description
Instead of passing when _any_ of `["CF-1.7", "CF-1.11", "CMIP-6.2"]` are present, they should be split up into CF conventions and CMIP conventions.
E.g. only passing when one of `["CF-1.7", "CF-1.11",]` _and_ `CMIP-6.2` is present.
Or better still would be to move the check for `CMIP` conventions into the compliance checker project plugins `cmip6`, `cmip7`, `cordex`. As checking for `CMIP` isn't part of the `CF` standards.
Also relevant is https://github.com/MetOffice/CDDS/issues/793
Contributor guide
No contributing guide indexed for this repository
Research direction
Start at the check_conventions_version QC plugins and trace how the CF and CMIP convention lists are evaluated. Review the related CDDS issue #793 and the compliance checker plugins for cmip6, cmip7, and cordex. Done means CF and CMIP checks are no longer conflated, with the intended convention combinations covered by tests.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100