MetOffice / MetOffice/CDDS

Investigate whether `test_fromfile_prefix_chars` is needed (currently marked as `xfail`)

Open
#776 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

quality assurance
Dominant language
Python
Stars
8
Forks
7
Avg merge
1d 15h
Merged PRs (30d)
23

Description

During the [update to python 3.12 ](https://github.com/MetOffice/CDDS/issues/768), this test was marked as xfail as it was failing after the update.

This issue is to check whether the test is needed at all, as it is related to older `Alter` code.

https://github.com/MetOffice/CDDS/blob/main/cdds/cdds/tests/test_prepare/test_command_line.py#L577

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with cdds/cdds/tests/test_prepare/test_command_line.py at the test_fromfile_prefix_chars test around line 577. Read the test and the surrounding command-line preparation code to determine whether it still covers supported behavior or only older Alter code. Run the relevant test to confirm its current xfail behavior; done means the test's necessity is established and the xfail is appropriately resolved.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
cli, testing-qa
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.