MetOffice / MetOffice/CDDS

generate_user_config_files is creating spurious masking entries in the config files

Open
#676 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
8
Forks
7
Avg merge
1d 15h
Merged PRs (30d)
23

Description

`generate_user_config_files` is creating spurious (and possibly erroneous?) masking entries.

```
[masking]
stream_ap5_cice-U = -1:None:None,180:None:None
stream_ap5_grid-V = -1:None:None,180:None:None
stream_ap6_cice-U = -1:None:None,180:None:None
stream_ap6_grid-V = -1:None:None,180:None:None
stream_onm_cice-U = -1:None:None,180:None:None
stream_onm_grid-V = -1:None:None,180:None:None
```

Looks like the problem is in the `get_masking_attributes` function.

https://github.com/MetOffice/CDDS/blob/574dd77aa358d6d8eadbb6e617547d830353308f/cdds/cdds/configure/user_config.py#L215-L225

Contributor guide

No contributing guide indexed for this repository

Research direction

Start in cdds/configure/user_config.py at get_masking_attributes around lines 215-225, then trace how generate_user_config_files consumes its result. Reproduce the generated config and compare the listed masking entries with the source attributes; done means spurious entries such as stream_ap5_cice-U and stream_onm_grid-V are no longer generated.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
tooling
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.