MetOffice / MetOffice/CDDS

Revise "VALID filter details" in CDDS Extract output

Open
#578 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
8
Forks
7
Avg merge
1d 15h
Merged PRs (30d)
23

Description

Following the refactoring of cdds extract to minimise the number of select queries being sent to MASS the STASH code is missing from the logs;

```
VALID filter details: --------------------
+ tnhus : CFmon constraint: [{'lbproc': 128, 'lbtim_ia': 1, 'lbtim_ib': 2}, {}] - ok
+ tnhusc : CFmon constraint: [{'lbproc': 128, 'lbtim_ia': 1, 'lbtim_ib': 2}, {}] - ok
```
Looking at the code [here](https://github.com/MetOffice/CDDS/blob/78c88698e198e8018a8e5236b3c2974a8ddd1da7/cdds/cdds/extract/process.py#L215-L229) the refactoring of the code to not have every entry associated with a single STASH means that it is difficult to present this information at this point in the code.

Recommend removing this section from the output and reinserting it earlier in the code, where the STASH entries are clearly linked to the constraints.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in cdds/cdds/extract/process.py around lines 215-229 and trace the earlier extraction flow where STASH entries are still linked to their constraints. Remove the existing VALID filter details output and reinsert it at that earlier point, then verify that CDDS Extract logs retain the STASH and constraint details.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
data-engineering
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.