Can we simplify `coord_systems._Definitions` and derived classes?
- Dominant language
- Python
- Stars
- 7
- Forks
- 10
- Avg merge
- 1d 19h
- Merged PRs (30d)
- 5
Description
# ✨ Feature Request
The [_Definitions](https://github.com/MetOffice/ANTS/blob/dbda2a48738af462776ad85da7ea308a6168a703/lib/ants/coord_systems.py#L187) class, and the derived classes Proj2CRS and Name2CRS can potentially be simplified. This may include simplifying the code that calls these classes.
In particular, the [GDAL docs](https://gdal.org/en/stable/doxygen/classOGRSpatialReference.html#a271b3de4caf844135b0c61e634860f2b) recommend against using `srs.ExportToProj4`, which is used by the code that calls these classes. So refactoring the calling code may avoid needing these classes at all.
## Requirements
This should be a refactor: no existing tests should need to be changed.
Contributor guide
Research direction
Start in lib/ants/coord_systems.py at _Definitions and its Proj2CRS and Name2CRS derived classes, then trace the calling code that uses srs.ExportToProj4. Compare that flow with the linked GDAL guidance and identify whether the classes or their callers can be simplified. Done means the refactor is complete without changing existing tests.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- backend
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100