MetOffice / MetOffice/ANTS

Replace ants.utils.coord.guess_bounds with the iris equivalent?

Open
#136 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

✨ enhancement
Dominant language
Python
Stars
7
Forks
10
Avg merge
1d 19h
Merged PRs (30d)
5

Description

# ✨ Feature Request
Iris 3 included some significant improvements to `guess_bounds`. We should evaluate whether some or all of the capabilities from the [ANTS wrapper](https://github.com/MetOffice/ANTS/blob/dbda2a48738af462776ad85da7ea308a6168a703/lib/ants/utils/coord.py#L64) are now redundant and can be removed.

## Context
Existing unittests provide a good safety net for checking no loss of functionality. Note that I think iris and ANTS have different capabilites around guessing bounds for time coordinates - it may be that we want to preserve existing ANTS behaviour and gain the extra iris capability.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the existing unit tests for ants.utils.coord.guess_bounds and compare their coverage with Iris 3's equivalent implementation. Review the linked ANTS wrapper, paying particular attention to time-coordinate behavior. Done means redundant wrapper functionality is removed only where safe, retained ANTS behavior is preserved, and the existing tests continue to pass.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
data
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.