MerginMaps / MerginMaps/mobile

Filtering SQL expressions for Postgres and shapefile

Open
#4,482 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement filtering
Dominant language
C++
Stars
388
Forks
87
Avg merge
2d 7h
Merged PRs (30d)
20

Description

Currently all the SQL expressions have been tested just on GeoPackages, but we also want to support Postgres and shapefiles by the specification. Prepare and test the code on Postgres layers. (Shape files should work, but needs to be verified)

TODO:
- [ ] single select and multiselect values don't work and crash silently, culprit is `IS` operator, in sqlite it is interpreted the same as `=` however in postgres it is used just to check for `NULL` values ([Sqlite docu](https://www.sqlite.org/lang_expr.html), [Postgres docu](https://www.postgresql.org/docs/current/functions-comparison.html))
- [ ] pass boolean values as `0`/`1` instead of `TRUE`/`FALSE` (shapefile doesn't support the later variant)

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Locate the SQL expression filtering code and the existing GeoPackage coverage, then prepare equivalent checks against Postgres layers and shapefile layers. Verify that single-select and multiselect values no longer fail silently, that comparisons use the correct operator for Postgres, and that boolean values are passed as 0/1 for shapefiles.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp, postgresql, sqlite
Domain
databases
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.