MerginMaps / MerginMaps/mobile

Optimize feature requests when identifying

Open
#4,126 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement map tools performance
Dominant language
C++
Stars
388
Forks
87
Avg merge
2d 7h
Merged PRs (30d)
20

Description

When identifying on the map canvas, be it single tap or tap and hold, a feature request is performed which fetches all attributes of all nearby features .
Most of the times this does not matter, but if a layer has an expensive attribute (eg virtual field with relation_aggregate expression) then the issue is apparent.

This can be optimized by fetching only what is needed, and only fetch the whole feature when we need to display its form:

  • single tap: FID and geometry are only needed for the proximity check
  • tap and hold: fields used in the display expression are only needed (no geometry)

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Trace map-canvas identification for single taps and tap-and-hold, then inspect where feature requests are constructed. The change is done when single taps fetch only FID and geometry, tap-and-hold fetches only fields needed for the display expression, and the full feature is fetched only when its form must be displayed.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
mobile, performance
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.