MerginMaps / MerginMaps/mobile
MerginApi class refactoring
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 388
- Forks
- 87
- Avg merge
- 2d 7h
- Merged PRs (30d)
- 20
Description
- [ ] Drop any support for `::OLD` server type (prior to workspaces), including API calls and classes (Make sure to log error and show big red error banner that this server version is not supported anymore)
- [ ] Clean up ping:
- [ ] Remove version check & api version status (should be read from `/config`)
- [ ] Remove `supports_subscription` check (should be read from `/config` ~> if server type is `::SAAS`)
- [ ] Drop `merginsubscriptioninfo` class (use `/v2/workspaces//service` instead)
- [ ] Drop / refactor `merginsubscriptionstatus` class
- [ ] Drop `serverwasupgraded`
- [ ] Rename prefix `Mergin` to `MM`... 😇
- [ ] Get rid of the auth event loop (Likely, see https://github.com/MerginMaps/mobile/blob/703d5a4078950b47740cd6841ef5d90f24364e3d/core/merginapi.cpp#L3120 and #3261)
- [x] Drop `userID` - we do not need it (done in https://github.com/MerginMaps/mobile/pull/3964)
- [ ] Drop `apiVersionStatus` - it clashes with other calls ... some calls like "refreshUserRole" randomly won't execute if this one is not loaded yet
- [ ] https://github.com/MerginMaps/mobile/issues/4015
- [ ] Define startup behaviors (new server, new installation, project preopened, server changes, offline, expired token, password, sso)
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with core/merginapi.cpp at the auth event-loop references around lines 3120 and 3261, then review issue #4015 and the completed userID change in pull request #3964. Done means resolving the remaining checklist items, including obsolete server and subscription classes, startup behaviors, and API-state handling.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- api, mobile-dev
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 20/100