MerginMaps / MerginMaps/mobile

Incomplete photo deletion

Open
#3,868 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug photo-refactoring
Dominant language
C++
Stars
388
Forks
87
Avg merge
2d 7h
Merged PRs (30d)
20

Description

For a photo field, when adding a new feature form or editing an existing one, photos are not being deleted properly.
If we:
Scenario A:

  1. Open the form with a photo field by adding a new/editing an existing feature.
  2. Add a photo, then delete it.
  3. Add a different photo, then delete it.
  4. Add/save the feature.
    Scenario B:
  5. add new point
  6. attach photo to that point
  7. delete point with attached photo
  8. synch - the picture from deleted point is in QGIS and it should not be there.

Only the last photo will actually be deleted from the project folder.

See https://github.com/MerginMaps/mobile/pull/3839.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing Scenarios A and B in the mobile app, then read the related discussion in pull request 3839. Done means deleted photos, including photos attached to deleted points, are no longer left in the project folder or returned to QGIS after synchronization.

Written by the indexing model from the issue text.

Assessment

Tech stack
android, cpp, ios
Domain
mobile-dev
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.