MerginMaps / MerginMaps/mobile
Basefile is left in the project after a GeoPackage gets deleted
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 388
- Forks
- 87
- Avg merge
- 2d 7h
- Merged PRs (30d)
- 20
Description
From a client project dir and from a brief look into the code (`MerginApi::finalizeProjectPull()`), it looks like we do not remove basefiles of geopackages when they get deleted on the server, and they stay in the `.mergin` subdirectory.
This should be a way to replicate:
1. create a MM project with a.gpkg and b.gpkg
2. download the project to Input
3. delete a.gpkg on the MM server
4. sync the project in Input
5. if you look at the project directory, only b.gpkg is there, but in `.mergin` subdir, there's both a.gpkg and b.gpkg
It is a minor issue which should not cause sync problems, but it may occupy extra space on the device...
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in MerginApi::finalizeProjectPull() and reproduce the listed workflow with a project containing a.gpkg and b.gpkg. Trace deletion handling for the removed GeoPackage and verify that syncing removes its basefile from the project's .mergin directory while retaining b.gpkg.
Written by the indexing model from the issue text.
Assessment
- Domain
- databases, mobile
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100