MerginMaps / MerginMaps/mobile
Code coverage check incorrectly compares to previous build
Open
Nobody has claimed this yet.
enhancement
infrastructure
- Dominant language
- C++
- Stars
- 388
- Forks
- 87
- Avg merge
- 2d 7h
- Merged PRs (30d)
- 20
Description
It seems that code coverage check currently compares coverage to previous build on the same branch. It is fine for master branch, but in feature branches this is wrong due to scenarios like this:
Let's say initial code coverage is 60%,
- create commit A (without autotests), coverage drops to 59.5% - check fails (✔️ )
- create commit B (without autotests), coverage drops to 59% - check fails (✔️ )
- create commit C (without autotests, but only fix layout), coverage is still 59% - check succeeds because it compares to previous build (❌ ) .. However, overall coverage still dropped by 1%.
I guess we should always compare to last master build?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No file or test is named. Start by locating the CI configuration and code-coverage check that compares a branch build with the previous build, then trace how master and feature branches are selected; done means the repeated-commit scenario is covered by a regression check and the intended baseline behavior is documented.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- ci-cd, testing-qa
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100