Mergifyio / Mergifyio/mergify

Show warning if assignee is trying to merge a PR without reviews

Open
#5,126 11 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
No language data
Stars
339
Forks
93
PR merge metrics
No merged PRs in 30d

Description

Expected Behavior

PR shouldn't be merged when PR has no reviews or if assignee is trying to merge it.

Actual Behavior

PR was getting merged

Steps to Reproduce the Problem

  1. We have below configuration in mergify.yaml
  ---
pull_request_rules:
  - name: automatic merge
    conditions:
      - label!=DNM
      - label!=work-in-progress
      - base=master
      - "approved-reviews-by=@red-hat-storage/cephci-top-level-reviewers"
      - "check-success=tox (3.9.18)"
      - check-success=WIP
    actions:
      merge:
        method: merge
  - name: ask to resolve conflict
    conditions:
      - conflict
    actions:
      comment:
        message: >
          "This pull request now has conflicts with the target branch.
          Could you please resolve conflicts and force push the corrected
          changes?"
  1. So anyone can have a label approved in labels, so its getting merged.
  2. Can we have a condition in above configuration file in such a way only when reviewers keep label as approved, PR should get merged.

Specifications

  • Pull Request URL:
  • Mergify Config URL:

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the mergify.yaml example and trace how approved-reviews-by, labels, assignees, and merge actions are evaluated. Reproduce the case where an approved label permits merging without a qualifying review, then verify that the configured policy distinguishes reviewer approval and assignee attempts before merging.

Written by the indexing model from the issue text.

Assessment

Tech stack
github, python, yaml
Domain
ci-cd, devops
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.