Bug: Successful check hides failed check of same name
Open
Nobody has claimed this yet.
- Dominant language
- No language data
- Stars
- 339
- Forks
- 93
- PR merge metrics
- No merged PRs in 30d
Description
Expected Behavior
If a PR has 2 check runs with the same name, and one fails and one succeeds, after they both finish
"#check-failure=1"should betrue"#check-success=1"should betrue
Actual Behavior
Tested with the Mergify config editor against a more complex PR that has been closed and merged, effectively the results are
"#check-failure=1"isfalse"#check-failure=0"istrue"#check-success=1"istrue
Steps to Reproduce the Problem
- Create two workflows (different files) with the same job name. One workflow always succeeds, one workflow always fails.
- Use a Mergify configuration with condition checking for zero pending, 1 failure, 1 success.
- See that the condition is never satisfied, because at the end of the runs,
"#check-failure=1"isfalse.
Specifications
More details in this discussion
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the linked discussion and reproduce the issue using two workflows with the same job name, one succeeding and one failing. Trace how the Mergify configuration evaluates #check-failure and #check-success for those GitHub check runs; done means both conditions report a count of one.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- github, python
- Domain
- ci-cd
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100