Mergifyio / Mergifyio/mergify

Bug: Successful check hides failed check of same name

Open
#5,083 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
No language data
Stars
339
Forks
93
PR merge metrics
No merged PRs in 30d

Description

Expected Behavior

If a PR has 2 check runs with the same name, and one fails and one succeeds, after they both finish

  • "#check-failure=1" should be true
  • "#check-success=1" should be true

Actual Behavior

Tested with the Mergify config editor against a more complex PR that has been closed and merged, effectively the results are

  • "#check-failure=1" is false
  • "#check-failure=0" is true
  • "#check-success=1" is true

Steps to Reproduce the Problem

  1. Create two workflows (different files) with the same job name. One workflow always succeeds, one workflow always fails.
  2. Use a Mergify configuration with condition checking for zero pending, 1 failure, 1 success.
  3. See that the condition is never satisfied, because at the end of the runs, "#check-failure=1" is false.

Specifications

More details in this discussion

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the linked discussion and reproduce the issue using two workflows with the same job name, one succeeding and one failing. Trace how the Mergify configuration evaluates #check-failure and #check-success for those GitHub check runs; done means both conditions report a count of one.

Written by the indexing model from the issue text.

Assessment

Tech stack
github, python
Domain
ci-cd
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.