Missing CODEOWNERS fails to merge PR ungracefully
Nobody has claimed this yet.
- Dominant language
- No language data
- Stars
- 339
- Forks
- 93
- PR merge metrics
- No merged PRs in 30d
Description
On a PR that had been approved, but not by codeowners we get the error message:
Branch protection settings are blocking automatic merging See: https://doc.mergify.io/faq.html#mergify-is-unable-to-merge-my-pull-request-due-to-my-branch-protection-settings
GitHub error message: Waiting on code owner review from ...
This is pretty misleading because it looks like mergify is broken, but it is actually expected that it isn't merged.
Is it possible for mergify to expect codeowners approval?
Note - this is pretty much a cosmetic issue only
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing the branch-protection and automatic-merge error handling described in the report, then compare it with the linked FAQ and GitHub's code-owner review message. Done means the expected waiting state is distinguished from an actual merge failure and the resulting user-facing behavior is verified.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- github
- Domain
- ci-cd
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 30/100