Merck / Merck/psm3mkv

Replace survival and hazard function calls with standsurv

Open
#14 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
R
Stars
11
Forks
4
PR merge metrics
No merged PRs in 30d

Description

The standsurv post-estimation command of flexsurv is not currently used, although psm3mkv already depends on flexsurv. Therefore some code in psm3mkv is redundant or inefficient.

Go through code and replace calls to calc_surv() and calc_haz().
Ideally also remove convert_fit2spec().

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Search the psm3mkv code for calc_surv(), calc_haz(), and convert_fit2spec(), then compare their uses with flexsurv's standsurv interface. Done means the redundant calls are replaced where appropriate and convert_fit2spec() is removed if it is no longer needed.

Written by the indexing model from the issue text.

Assessment

Tech stack
r
Domain
backend
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.