A lot of if-else in `format_ae_listing()`
@fukuhiro2023 is already working on this.
Since Sep 16, 2026.
- Dominant language
- R
- Stars
- 22
- Forks
- 6
- Avg merge
- 1d 12h
- Merged PRs (30d)
- 7
Description
We have a lot of `if` statements in the `format_ae_listing()` function handling various tasks (see https://github.com/Merck/forestly/blob/main/R/ae_listing.R#L336-L508), including simple ones like converting to title case or relabeling columns. It also includes some calculations, as seen in lines [465-506](https://github.com/Merck/forestly/blob/main/R/ae_listing.R#L465-L506).
I am wondering if these if-else statements are redundant, considering:
- Variable names might differ from one study to another.
- They may slow down execution time.
- Should we just display exactly what is already in the dataset?
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.