Merck / Merck/Halyard

Poor performance of nested OPTIONALs

Open
#72 1 comment 0 reactions 1 assignee View on GitHub

@asotona is already working on this.

Since Sep 9, 2019.

bug
Dominant language
Java
Stars
114
Forks
18
PR merge metrics
No merged PRs in 30d

Description

When you have a SPARQL query with nested OPTIONAL clauses, such as the following, it's performance is poor, typically causing timeouts.

PREFIX bibo:    <http://purl.org/ontology/bibo/>
PREFIX dcterms: <http://purl.org/dc/terms/>

SELECT *
WHERE {
  {
    SELECT ?article
    WHERE {
      ?article a bibo:Article .
    }
    LIMIT 10
  }

  OPTIONAL {
    OPTIONAL {
      ?article dcterms:issued ?article_issued .
    }
  }
}

Output of Halyard Profile for this query:

Optimized query:
    Projection [2,955,991,897,878,706.5]
        ProjectionElemList
            ProjectionElem "article"
            ProjectionElem "article_issued"
        LeftJoin [2,955,991,897,878,706.5]
            Slice ( limit=10 ) [3,614,563.841]
                Projection [3,614,563.841]
                    ProjectionElemList
                        ProjectionElem "article"
                    StatementPattern [3,614,563.841]
                        Var (name=article)
                        Var (name=_const_f5e5585a_uri, value=http://www.w3.org/1999/02/22-rdf-syntax-ns#type, anonymous)
                        Var (name=_const_6dd7acd3_uri, value=http://purl.org/ontology/bibo/Article, anonymous)
            LeftJoin [226.251]
                SingletonSet [1]
                StatementPattern [226.251]
                    Var (name=article)
                    Var (name=_const_884f353b_uri, value=http://purl.org/dc/terms/issued, anonymous)
                    Var (name=article_issued)

The nested OPTIONAL in this query is unnecessary, but it allows to replicate the issue without in a minimal way.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.