improve support for embed url-arguments
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 46
- Forks
- 24
- PR merge metrics
- No merged PRs in 30d
Description
As discussed on Discord.
E.g. https://strims.gg/youtube-playlist/PLJbWNarT9D8msO9D8p3nvq7Wj9FBQvvkC&index=41
works, notice the index= with & (not ?) probably coincidentally, however the amount of viewers is not counted probably because there are problems with using the "incurrent" URL internally...
Links like these should work as expected (counting viewers, also the same "trick" with a t= parameter for normal yt embeds breaks the embed) and probably count towards viewers on the version with the index= parameter (i.e. normalize the url for keeping track). it would be nice though to keep supporting adding paramters for the embed-url, like youtube-start-time parameter (t=).
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing how embed URLs are parsed and how the internal "incurrent" URL is used for viewer counting. Reproduce the playlist link with the index= argument and a normal YouTube embed with t=; done means both render correctly, count viewers, and preserve supported embed parameters while normalized URLs share viewer counts.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- frontend, web-dev
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100