MeltanoLabs / MeltanoLabs/tap-postgres
Don't rely on tap's local time and target servers time to do a timeout
Open
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 26
- Forks
- 42
- PR merge metrics
- No merged PRs in 30d
Description
We shouldn't rely on a local time to compare with the time on the postgres server. Can we instead just record the current time stamp on the local machine and then compare the current timestamp here to see if 5 seconds has elapsed instead of worrying about the timestamp from postgres? This way we don't need to work about skew
Originally posted by @visch in https://github.com/MeltanoLabs/tap-postgres/pull/249#discussion_r1357353361
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
The issue does not name a file or test. Locate the timeout logic that compares local and PostgreSQL timestamps, then inspect nearby tests or add a focused test for clock skew. Done means the five-second timeout is measured using elapsed time on the local machine without relying on PostgreSQL's timestamp.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- postgresql, python
- Domain
- databases
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 32/100