MeltanoLabs / MeltanoLabs/tap-postgres

Review config being overriden in `client.py`

Open
#264 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
26
Forks
42
PR merge metrics
No merged PRs in 30d

Description

Why are we overriding this?

Originally posted by @visch in https://github.com/MeltanoLabs/tap-postgres/pull/249#discussion_r1357338576

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading client.py and the configuration-handling discussion in pull request #249, especially the linked review comment. Determine the intended behavior for the overridden configuration, then document the decision and update client.py if a change is agreed upon.

Written by the indexing model from the issue text.

Assessment

Tech stack
postgresql, python
Domain
databases
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
20/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.