MeltanoLabs / MeltanoLabs/tap-postgres

Review comment in client.py

Open
#262 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
26
Forks
42
PR merge metrics
No merged PRs in 30d

Description

          Is this true? I don't think that's the reason you turn type conformance on.

Originally posted by @visch in https://github.com/MeltanoLabs/tap-postgres/pull/249#discussion_r1357338238

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Read client.py around type conformance and review the linked pull request discussion. Determine what the comment is questioning and whether a documentation change is actually needed; done means the concern has a decided resolution and the explanation is corrected or the issue is closed as unnecessary.

Written by the indexing model from the issue text.

Assessment

Tech stack
postgresql, python
Domain
databases
Issue type
Documentation
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
20/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.