MeltanoLabs / MeltanoLabs/tap-postgres
Refactor client.py discover_catalog_entry
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 26
- Forks
- 42
- PR merge metrics
- No merged PRs in 30d
Description
Can we get rid of this whole function override and just override the setter for `replication_key` if LOG_BASED then `_sdc_lsn` , also we should mention this in the docs (that the replication key is automatically set to _sdc_lsn which is the lsn number from (link to page)
Originally posted by @visch in https://github.com/MeltanoLabs/tap-postgres/pull/249#discussion_r1357334912
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in client.py by locating discover_catalog_entry and the replication_key handling, then review how LOG_BASED is represented. Remove the function override in favor of the requested replication_key setter behavior, and update the relevant documentation to explain that LOG_BASED automatically uses _sdc_lsn from the PostgreSQL LSN. The issue names no tests, so verify the existing client behavior and documentation changes against the stated requirements.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- postgresql, python
- Domain
- database, documentation
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100