MeltanoLabs / MeltanoLabs/tap-github

Add missing fields to PR stream

Open
#49 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
20
Forks
60
Avg merge
20h 29m
Merged PRs (30d)
6

Description

Currently the PR stream is missing a bunch of key fields
```
additions
deletions
review_comments (int)
changed_files (int)
..etc
```
The current api route we use https://docs.github.com/en/rest/reference/pulls#list-pull-requests isn't sufficient to get all these missing fields. We would need to use the singular pr route https://docs.github.com/en/rest/reference/pulls#get-a-pull-request to fetch everything. This may be difficult since this would greatly increase the amount of requests made to the API. We could maybe cut this down by making a custom query with absolutely everything with #48.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing the PR stream implementation and compare the fields available from the list pull requests route with the singular get-a-pull-request route in the linked GitHub API documentation. Review issue #48 for the possible custom query, then define a way to expose additions, deletions, review_comments, changed_files, and other required fields without an unacceptable increase in API requests.

Written by the indexing model from the issue text.

Assessment

Tech stack
github, python
Domain
api, data-engineering
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.