MeltanoLabs / MeltanoLabs/tap-github
Allow GithubStream to continue on specific errors
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 20
- Forks
- 60
- Avg merge
- 20h 29m
- Merged PRs (30d)
- 6
Description
As I was implementing a GithubStream for community_profile, I stumbled upon the following issue:
Some repos actually return a 404 when we request their community_profile. It is quite lucky that this got caught early thanks to the main test repo being one of these edge-cases. Though I still do not understand why.
- https://api.github.com/repos/facebook/react/community/profile works...
- https://api.github.com/repos/MeltanoLabs/target-athena/community/profile doesn't work 🤯 -> 404
As a workaround, we could allow tolerated_http_errors and handle them differently. This is what I have implemented here. But I am open to other ideas 😄
Open question:
- Is it worth implementing at the SDK level? This seems a bit specific to GitHub but 🤷
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by comparing the GitHub community_profile responses for facebook/react and MeltanoLabs/target-athena, then review the workaround linked in the issue. Determine whether tolerated HTTP errors belong in the SDK or only this tap; done means the chosen scope and behavior for the 404 case are defined and covered by tests.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- github, python
- Domain
- api, backend
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100