MeltanoLabs / MeltanoLabs/Singer-Working-Group
Best Practice Target Capability: Data Type Failsafe
Open
@aaronsteers is already working on this.
Since Oct 25, 2021.
- Dominant language
- No language data
- Stars
- 15
- Forks
- 4
- PR merge metrics
- No merged PRs in 30d
Description
We've run into many, many cases where a specific target receives a JSON schema type that it doesn't expect and then immediately terminates the entire stream.
Rather than failing the sync entirely, we'd like to propose a best practice of always having a failsafe data type which handles two common scenarios:
- A
catchfor parsing exceptions when reading the json schema type. For instance, a$refor missingpropertiescan causeKeyErrorduring type evaluation. These should be caught and handled with a default type - such asstring. - A final
elsestatement at the end of all known cases. Similarly as with the above, if all known cases are evaluated and we've received a type we don't recognize, we should again default tostringof similar so that the node's data can still be serialized without terminating the sync.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.