Megvii-BaseDetection / Megvii-BaseDetection/YOLOX

In coco.py line200 comment is wrong which is easy to misleading users.

Open Beginner friendly
#810 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
10.6k
Forks
2.5k
PR merge metrics
No merged PRs in 30d

Description

https://github.com/Megvii-BaseDetection/YOLOX/blob/6880e3999eb5cf83037e1818ee63d589384587bd/yolox/data/datasets/coco.py#L200
I try to create a new dataset class in order to feed my own data, and I found that the following comment is wrong:

# coco.py line 200
'''
padded_labels (torch.Tensor): pre-processed label data.
    The shape is :math:`[max_labels, 5]`.
    each label consists of [class, xc, yc, w, h]:
        class (float): class index.
        xc, yc (float) : center of bbox whose values range from 0 to 1.
        w, h (float) : size of bbox whose values range from 0 to 1.
'''

the correct comment is like this:

'''
target (numpy.ndarray): pre-processed label data.
    The shape is :math:`[max_labels, 5]`.
    each label consists of [x1, y1, x2, y2, class]:
        class (float): class index.
        x1, y1 (float) : top-left points whose values range from 0 to 640
        x2, y2 (float) : right-down points whose values range from 0 to 640
'''

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Open yolox/data/datasets/coco.py at line 200 and compare the existing documentation with the target array format shown in the issue. Update the comment so it describes target, [x1, y1, x2, y2, class], and the stated coordinate ranges; done when the documentation matches the actual label data.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
computer-vision
Issue type
Documentation
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
68/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.