MegaMek / MegaMek/megamek

Ammo with kg-per-shot oddities

Open
#2,425 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Data Needs Investigation Outdated ProtoMek
Dominant language
Java
Stars
358
Forks
376
Avg merge
1d 4h
Merged PRs (30d)
128

Description

The following AmmoTypes have oddities w.r.t. their kg-per-shot values. These were noted while debugging https://github.com/MegaMek/mekhq/pull/2241.

BattleArmor Ammo without kg-per-shot:
- [ ] BA-Micro Bomb Ammo
- [ ] Clan Torpedo/LRM5 Ammo
- [ ] BA-Mine Launcher Ammo
- [ ] BA Taser Ammo
- [ ] BARL1 Ammo
- [ ] BARL2 Ammo
- [ ] BARL3 Ammo
- [ ] BARL4 Ammo
- [ ] BARL5 Ammo

Ammo declaring kg-per-shot whose shots-per-ton in MHQ would be incorrectly calculated (MHQ only uses kg-per-shot with BA ammo):

**non-BA ammo not in your favor**
- [ ] CLAMS Ammo (24 shots @ 40 kg-per-shot, MHQ would charge you for 1 ton but only ship you 960 kg)
- [ ] Clan LB 2-X AC Ammo (45 shots @ 20 kg-per-shot, MHQ would charge you for 1 ton but only ship you 900 kg)
- [ ] Clan Ultra AC/2 Ammo (45 shots @ 20 kg-per-shot, MHQ would charge you for 1 ton but only ship you 900 kg)
- [ ] CL Heavy Flamer Ammo (10 shots @ 10 kg-per-shot, MHQ would charge you for 1 ton but only ship you 100 kg)
- [ ] Clan Streak LRM 1 Ammo (1 shot @ 8.33 kg-per-shot, MHQ would charge you for 1 ton but only ship you 8.33 kg)
- [ ] Clan Streak LRM 2 Ammo
- [ ] Clan Streak LRM 3 Ammo
- [ ] Clan Streak LRM 4 Ammo
- [ ] Clan Streak LRM 6 Ammo
- [ ] Clan Streak LRM 7 Ammo
- [ ] Clan Streak LRM 8 Ammo
- [ ] Clan Streak LRM 9 Ammo
- [ ] Clan Streak LRM 11 Ammo
- [ ] Clan Streak LRM 12 Ammo
- [ ] Clan Streak LRM 13 Ammo
- [ ] Clan Streak LRM 14 Ammo
- [ ] Clan Streak LRM 16 Ammo
- [ ] Clan Streak LRM 17 Ammo
- [ ] Clan Streak LRM 18 Ammo
- [ ] Clan Streak LRM 19 Ammo
- [ ] Clan Ammo Protomech LRM-1 (100 shots @ 8.33 kg-per-shot, MHQ would charge you for 1 ton but only ship you 833 kg)
kg)
- [ ] Clan Ammo SRM-6 (15 shots @ 60 kg-per-shot, MHQ would charge you for 1 ton but only ship you 900 kg)
- [ ] Clan Streak SRM 2 Ammo (50 shots @ 10 kg-shot, MHQ would charge you for 1 ton but only ship you 500 kg)
- [ ] Clan Streak SRM 6 Ammo (15 shots @ 60 kg-shot, MHQ would charge you for 1 ton but only ship you 900 kg)
- [ ] ISNarc Pods (6 shots @ 150 kg-shot, MHQ would charge you for 1 ton but only ship you 900 kg)
- [ ] ISNarc ExplosivePods (6 shots @ 150 kg-shot, MHQ would charge you for 1 ton but only ship you 900 kg)
- [ ] CLNarc ExplosivePods (6 shots @ 150 kg-shot, MHQ would charge you for 1 ton but only ship you 900 kg)
- [ ] Clan Ammo Protomech LRTorpedo-1 (100 shots @ 8.33 kg-shot, MHQ would charge you for 1 ton but only ship you 833 kg)
- [ ] Clan Ammo SRTorpedo-6 (15 shots @ 60 kg-shot, MHQ would charge you for 1 ton but only ship you 900 kg)
- [ ] ClanImprovedLRM5Ammo (24 shots @ 8.33 kg-per-shot, MHQ would charge you for 1 ton but only ship you ~200 kg)
- [ ] ClanImprovedLRM10Ammo (12 shots @ 8.33 kg-per-shot, MHQ would charge you for 1 ton but only ship you ~100 kg)
- [ ] ClanImprovedLRM15Ammo (8 shots @ 8.33 kg-per-shot, MHQ would charge you for 1 ton but only ship you ~75 kg)
- [ ] ClanImprovedLRM20Ammo (6 shots @ 8.33 kg-per-shot, MHQ would charge you for 1 ton but only ship you ~50 kg)
- [ ] ClanImpAmmoSRM2 (50 shots @ 10 kg-per-shot, MHQ would charge you for 1 ton but only ship you 500 kg)
- [ ] ClanImpAmmoSRM4 (25 shots @ 10 kg-per-shot, MHQ would charge you for 1 ton but only ship you 250 kg)
- [ ] ClanImpAmmoSRM6 (15 shots @ 10 kg-per-shot, MHQ would charge you for 1 ton but only ship you 150 kg)

**non-BA ammo in your favor**
- [ ] Clan Ammo Protomech LRM-2 (100 shots @ 16.66 kg-per-shot, MHQ would charge you for 1 ton but ship you 1,666 kg!)
- [ ] Clan Ammo Protomech LRM-3
- [ ] Clan Ammo Protomech LRM-4
- [ ] Clan Ammo Protomech LRM-6
- [ ] Clan Ammo Protomech LRM-7
- [ ] Clan Ammo Protomech LRM-8
- [ ] Clan Ammo Protomech LRM-9
- [ ] Clan Ammo Protomech LRM-11
- [ ] Clan Ammo Protomech LRM-12
- [ ] Clan Ammo Protomech LRM-13
- [ ] Clan Ammo Protomech LRM-14
- [ ] Clan Ammo Protomech LRM-16
- [ ] Clan Ammo Protomech LRM-17
- [ ] Clan Ammo Protomech LRM-18
- [ ] Clan Ammo Protomech LRM-19
- [ ] Clan Ammo SRM-3 (100 shots @ 30 kg-per-shot, MHQ would charge you for 1 ton but ship you 3,000 kg!)
- [ ] Clan Ammo SRM-5 (100 shots @ 50 kg-per-shot, MHQ would charge you for 1 ton but ship you 5,000 kg!)
- [ ] Clan Streak SRM 3 Ammo (100 shots @ 30 kg-per-shot, MHQ would charge you for 1 ton but ship you 3,000 kg!)
- [ ] Clan Streak SRM 5 Ammo (100 shots @ 50 kg-per-shot, MHQ would charge you for 1 ton but ship you 5,000 kg!)
- [ ] Clan Ammo Protomech LRTorpedo-2 (100 shots @ 16.66 kg-shot, MHQ would charge you for 1 ton but ship you 1,666 kg!)
- [ ] Clan Ammo Protomech LRTorpedo-3
- [ ] Clan Ammo Protomech LRTorpedo-4
- [ ] Clan Ammo Protomech LRTorpedo-6
- [ ] Clan Ammo Protomech LRTorpedo-7
- [ ] Clan Ammo Protomech LRTorpedo-8
- [ ] Clan Ammo Protomech LRTorpedo-9
- [ ] Clan Ammo Protomech LRTorpedo-11
- [ ] Clan Ammo Protomech LRTorpedo-12
- [ ] Clan Ammo Protomech LRTorpedo-13
- [ ] Clan Ammo Protomech LRTorpedo-14
- [ ] Clan Ammo Protomech LRTorpedo-16
- [ ] Clan Ammo Protomech LRTorpedo-17
- [ ] Clan Ammo Protomech LRTorpedo-18
- [ ] Clan Ammo Protomech LRTorpedo-19
- [ ] Clan Ammo SRTorpedo-3 (100 shots @ 30 kg-per-shot, MHQ would charge you for 1 ton but ship you 3,000 kg!)
- [ ] Clan Ammo SRTorpedo-5 (100 shots @ 50 kg-per-shot, MHQ would charge you for 1 ton but ship you 5,000 kg!)

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Use the checklist in issue 2425 as the acceptance scope. Trace the AmmoTypes definitions and the MHQ kg-per-shot and shots-per-ton calculation, then verify each listed ammo type against the intended mass. Done means the missing or inconsistent values are corrected and the affected calculations are validated.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
game-dev
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.