MeasureTransport / MeasureTransport/MParT

Bug in ppc conda package

Open
#303 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
C++
Stars
18
Forks
5
PR merge metrics
No merged PRs in 30d

Description

Found using the conda installation on Satori. The log-determinant of affine maps is wrong. It seems like the value of the determinant is getting rounded at some point (note: I changed the python test to compare the determinant here, not the log-determinant).

E       AssertionError: assert False
E        +  where False = <function allclose at 0x7ff759de30d0>(array([7., 7., 7., 7., 7., 7., 7., 7., 7., 7.]), 7.500000000000003, atol=1e-08)
E        +    where <function allclose at 0x7ff759de30d0> = np.allclose
E        +    and   array([7., 7., 7., 7., 7., 7., 7., 7., 7., 7.]) = <ufunc 'exp'>(array([1.94591015, 1.94591015, 1.94591015, 1.94591015, 1.94591015,\n       1.94591015, 1.94591015, 1.94591015, 1.94591015, 1.94591015]))
E        +      where <ufunc 'exp'> = np.exp
E        +    and   7.500000000000003 = <function det at 0x7ff759c895e0>(array([[ 1. ,  2. ],\n       [-3. ,  1.5]]))
E        +      where <function det at 0x7ff759c895e0> = <module 'numpy.linalg' from '/nobackup/users/mcbrenn/.conda/envs/mpart-conda/lib/python3.9/site-packages/numpy/linalg/__init__.py'>.det
E        +        where <module 'numpy.linalg' from '/nobackup/users/mcbrenn/.conda/envs/mpart-conda/lib/python3.9/site-packages/numpy/linalg/__init__.py'> = np.linalg

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the failure from the modified Python test described in the issue using the conda installation on Satori, then trace the affine-map log-determinant implementation across the Python and C++ package layers. The fix is done when the determinant for the shown matrix is preserved as 7.5 rather than rounded to 7 and the regression test passes.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp, numpy, python
Domain
backend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
32/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.