MeasureTransport / MeasureTransport/MParT

More extensible layout for cholesky

Open
#299 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C++
Stars
18
Forks
5
PR merge metrics
No merged PRs in 30d

Description

Currently, the cholesky requires you to have LayoutLeft for the sake of CUBLAS requiring it. This is somewhat irritating because the OpenMP backend of kokkos has a default layout of LayoutRight, so when I sample with the Gaussian distribution, I have to call the SampleImpl function directly, lest I want to get a runtime error that says I'm trying to use an incompatible LayoutRight View (i.e. I can't use the default Layout for Views when interacting with the Cholesky, namely within the Gaussian distribution).

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing the Cholesky layout requirements and its CUBLAS interaction, then compare them with the OpenMP backend's default LayoutRight behavior. Done means Gaussian sampling can use the default LayoutRight View with Cholesky without calling SampleImpl directly or triggering an incompatible-layout runtime error.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
hpc
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.