MeasureTransport / MeasureTransport/MParT

Set `basisUB` and `basisLB` in default `MapOptions`

Open
#285 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

discussion
Dominant language
C++
Stars
18
Forks
5
PR merge metrics
No merged PRs in 30d

Description

Given the numerical issues seen in #283, it seems to be a good idea to make the default for MapOptions to include finite values for basisLB and basisUB. The main question is what should they be? +/-3 seems to work well for centered and unit-variance data, but in the general maps-from-samples case, the bounds should probably depend on the samples.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the MapOptions definition and review the numerical issues described in #283. Decide how finite basisLB and basisUB defaults should behave for centered, unit-variance data and for maps built from samples; done means the default choice is specified for both cases.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
backend
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.