MeasureTransport / MeasureTransport/MParT
Function Class with no coefficients
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 18
- Forks
- 5
- PR merge metrics
- No merged PRs in 30d
Description
I think I'm playing catch up here with what you all have been talking about for >1 month, but (as much as I hate to admit it), there definitely should be a FunctionBase or NonParameterizedFunctionBase Base class for the maps that don't have coefficients. At this point, we have a few types of maps (AffineMap, IdentityMap) that don't have coefficients, where we end up just using assert(false) on the coefficient-dependent functions that the class inherits. If we add more like this (not sure what, but I would believe this to be possible), it would be nice to have a nonparametric version.
Before someone jumps the gun and calls this a repeat, I believe fixing this will largely fix #254 .
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by comparing the AffineMap and IdentityMap types with the coefficient-dependent functions they inherit, then review the related discussion in issue #254. The work is done when non-coefficient map types have an appropriate base-class design instead of relying on assert(false) for coefficient-dependent functions.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- backend
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100