McMaster-Baja-Racing / McMaster-Baja-Racing/Better-Data-Viewer

Merge SMOOTH_STRICT_SEC and SMOOTH_STRICT_PRIM into one analyzer

Open
#334 0 comments 0 reactions 1 assignee View on GitHub

@hans-hc is already working on this.

Since Feb 18, 2026.

backend code quality
Dominant language
TypeScript
Stars
3
Forks
2
PR merge metrics
No merged PRs in 30d

Description

Currently there are two separate analyzers for smooth strict RPM; one for PRIM, one for SEC.

The Smooth Strict RPM preset uses both of them

  {
    name: 'Smooth Strict RPM',
    description: 'Primary and Secondary RPM vs Timestamp (ms) smoothened with strict timestamp outlier removal',
    graphs: [
      {
        axes: [
          { source: 'RPM PRIM.csv', dataType: 'Timestamp (ms)' },
          { source: 'RPM PRIM.csv', dataType: 'RPM PRIM' },
        ],
        analyzer: AnalyzerType.SMOOTH_STRICT_PRIM,
        analyzerOptions: [],
        graphType: 'line',
      },
      {
        axes: [
          { source: 'RPM SEC.csv', dataType: 'Timestamp (ms)' },
          { source: 'RPM SEC.csv', dataType: 'RPM SEC' },
        ],
        analyzer: AnalyzerType.SMOOTH_STRICT_SEC,
        analyzerOptions: [],
        graphType: 'line',
      },
    ],
  },

Not sure why they are separated. I recall there was a reason but I don't remember why.

Look into a way to combine them into one SMOOTH_STRICT_RPM analyzer.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.