McMaster-Baja-Racing / McMaster-Baja-Racing/Better-Data-Viewer

Be more specific in typing x, y and z

Open
#243 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
TypeScript
Stars
3
Forks
2
PR merge metrics
No merged PRs in 30d

Description

Feature Description
It's a recurring problem to have x, y and z columns be sometimes undefined or unclear or nullable. We should separate this logic out somewhere and control it centrally instead of being all willy nilly.

        const axisDef = currGraph.axes[idx];
        if (!axisDef) return null;
        return {
          header: axisDef.axis,
          filename: `${fileKeys[0]}/${axisDef.file}`,
          timespan: { start: null, end: null }
        };
      });```

For example, instead of extracting this manually, write a helper function thats more in-depth and specific to the x, y, z approach.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the dataColumnKeys mapping and the Column type shown in the issue, then trace how x, y, and z axis definitions are represented. Determine where the nullable and undefined cases are currently handled. Done means the x/y/z column construction is controlled by one specific helper with consistent types, but the issue does not name tests or a target file.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
28/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.