McManning / McManning/frojs-server

Domain namespaces do not segregate rooms

Open
#3 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
JavaScript
Stars
2
Forks
1
PR merge metrics
No merged PRs in 30d

Description

Via pull request #2, it looks like when different domain/ns sections use the same room name, clients are merged regardless of the ns.

Fix either by removing multi-domains/ns altogether or fixing segregation. The former might be the better solution for this sample project to avoid overcomplication.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Review pull request #2 and trace how domain/ns sections and room names are handled in the server. Determine whether the sample should remove multi-domain namespaces or enforce room segregation, then verify that identical room names in different namespaces no longer merge clients, or that the unsupported namespace behavior is removed.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, node.js
Domain
backend
Issue type
Bug
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
20/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.