McManning / McManning/BlueGraph

Adding new ports does not refresh existing instances

Open
#61 0 comments 2 reactions 1 assignee View on GitHub

@McManning is already working on this.

Since Feb 2, 2022.

bug
Dominant language
C#
Stars
256
Forks
36
PR merge metrics
No merged PRs in 30d

Description

Via #57 - when assets are reloaded and new ports have been introduced to the node script, the new ports are not added to existing node instances.

It may not need to serialize empty connections to new ports to all existing graph assets, which would probably make sense from a performance standpoint. But it should at the very least introduce the new ports when you open the editor for a graph (or an existing editor is refreshed).

I'm also wondering if it just makes sense to introduce a general purpose "graph fixer" either via an editor window for interactive corrections (again, possibly to resolve some issues with #57) or a broad stroke algorithm that runs through all graph assets and adds/removes ports, signals errors, changes behaviour references, etc.

I have an old ticket #20 that goes into the various problem cases in depth as well.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.