MaxOhn / MaxOhn/rosu-pp

Should classic + v2 be considered as lazer enabled in osu mania

Open
#75 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
139
Forks
69
PR merge metrics
No merged PRs in 30d

Description

Current Behavior

ScoreV2 + Classic -> Classic

Image

Expect Behavior

ScoreV2 + Classic -> Lazer

Test Code

use rosu_pp::Beatmap;

#[test]
fn calculate_batch() {
    // Kikai No Tsubasa (feat. Kasane Teto)
    let map = Beatmap::from_path("./resources/5269878.osu").unwrap();

    let cases = [(1u32 << 29, false), (0u32, true), (0u32, false)];

    println!("\n{:<12} {:<10} {:>10}", "mods", "lazer", "pp");
    println!("{}", "-".repeat(34));

    for (mods, lazer) in cases {
        let pp = rosu_pp::Performance::new(&map)
            .mods(mods)
            .lazer(lazer)
            .n_geki(6988)
            .n300(5064)
            .n_katu(1804)
            .n100(467)
            .n50(275)
            .misses(296)
            .calculate()
            .pp();

        println!("{:<12} {:<10} {:>10.2}", mods, lazer, pp);
    }
}

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the supplied Rust test and the rosu_pp::Performance builder, comparing the three listed mod and lazer cases. Done means the ScoreV2 + Classic case is treated as Lazer while the other cases retain their expected behavior, with the test output confirming the change.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
game-dev
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
64/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.