Max9545 / Max9545/What-s-Cookin-Refactory
.classList.add.('.all-cards') after no-results search occurs
Open
Nobody has claimed this yet.
bug
fix
- Dominant language
- JavaScript
- Stars
- 0
- Forks
- 0
- PR merge metrics
- No merged PRs in 30d
Description
As a user, when I search for something, but am alerted that there's no matching recipes for that search input, when I try to search for something else and do get a result, those results are shown in small cards.
- This bug can be fixed by looking at domUpdates lines 47 (where the removal of all-cards occurs) and being sure that class is then added (domUpdates line 4.5 is my suggestion)
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in domUpdates around line 47, where the all-cards class is removed after a no-results search. Trace the subsequent successful search flow and restore the class as indicated by the issue. Verify that searching with no results and then searching again shows the matching recipes in normal-sized cards.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100