MatterMiners / MatterMiners/lapis
Inverted definition of allocation and utilization
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 2
- Forks
- 1
- PR merge metrics
- No merged PRs in 30d
Description
I am currently under the impression that the definition of allocation and utilization might be inverted in
https://github.com/MatterMiners/lapis/blob/989b805d6db12b62dc06602a27b3ea7357ca41ed/lapis/drone.py#L88-L96
As levels is aequivalent to the amount of unallocated resources on the machine, the allocation and utilization should be given by
`self._allocation = min(resources)` and `self._utilisation = max(resources)` respectively or am I mistaken?
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with lapis/drone.py lines 88-96 and verify how the issue defines levels, allocation, and utilisation. Trace the relevant callers to understand the expected resource semantics, then check whether the current definitions match them. Done means the definitions are confirmed or corrected and the affected behavior is validated.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100