Materials-Consortia / Materials-Consortia/optimade-python-tools

Add `from_<x>` code paths to generic entry adapter

Open
#1,342 0 comments 0 reactions 1 assignee View on GitHub

@ml-evs is already working on this.

Since Sep 26, 2022.

adapters priority/low
Dominant language
Python
Stars
91
Forks
54
No merged PRs in 30d

Description

In #1296, I didn't add the generic from_<x> path to the base EntryAdapter's __getattr__. As we want to be able to call the adapter as Structure.from_pymatgen(), this might need some metaclass hacking.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.