MaterialDesignInXAML / MaterialDesignInXAML/F1InXAML

Double Parsing with culture

Open
#1 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C#
Stars
127
Forks
23
PR merge metrics
No merged PRs in 30d

Description

Hi,

Please add "CultureInfo.InvariantCulture" to all your double.Parse, as it won't work for some locals when trying to run the project (it was the case for me, I'm french and the comma is the decimal char).

I was able to run the project after adding it locally to all the Parse() methods.

Awesome project though ! :) I love the animations.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Search the project for every double.Parse call and inspect the surrounding parsing paths. Update the affected parsing calls so French and other locales work consistently; the issue is done when the project runs without locale-dependent parsing failures.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp
Domain
desktop
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.