Masterminds / Masterminds/semver
Recent changes to NewVersion regex break the "-ish" nature of the function - e.g. v24.02.05
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 1.4k
- Forks
- 168
- PR merge metrics
- No merged PRs in 30d
Description
This is problematic because many versions are date allocated in dev ops use cases.
NewVersion parsed these correctly before and this change will cause large problems for our existing versions. While not in spec, it is a common usage.
Since there is already the concept of StrictNewVersion and NewVersion, it seems like a bad idea to alter NewVersion like this.
Thoughts?
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate the NewVersion and StrictNewVersion parsing logic and reproduce the v24.02.05 case. Compare the current behavior with the earlier handling described in the issue, then add regression coverage showing that NewVersion accepts date-like versions while StrictNewVersion remains distinct; the existing parsing tests are the completion check.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100